search

linkedin / linkedin-gradle-plugin-for-apache-hadoop

Apache License 2.0
117 stars 76 forks source link

Refactor AzkabanHelper to avoid System#console calls #255

Closed DPUkyle closed 5 years ago

DPUkyle commented 5 years ago

The azkabanUpload task relies on System#console calls to receive credentials. This requires user/environment special behavior to disable the Gradle daemon via the GRADLE_OPTS env var, --no-daemon CLI or other means.

This PR replaces that behavior with a better option, project.ant.input. This leverages Gradle's bundled ant instance to collect input, and should allow the Gradle daemon to be used for building azkaban zips.

...unfortunately I have no idea how to test this :) I'll get in touch with the owners via other means.

DPUkyle commented 5 years ago

This change was untested (and has no test coverage) and in retrospect does not work.

Note that there is no better solution currently; see gradle/gradle#2842