linkedin / openhouse

Open Control Plane for Tables in Data Lakehouse
https://www.openhousedb.org/
BSD 2-Clause "Simplified" License
273 stars 43 forks source link

HTS concurrent put and delete resolution -- Reopen and Refractor tests #89

Closed jiang95-dev closed 2 months ago

jiang95-dev commented 2 months ago

Summary

Bug fix for the reverted pr. This PR refractors the fragile unit tests. The save() method will change the state of the hts storage, so we need to delete all instances after each test to prevent the state propagation. The save() method will also update the version of TEST_USER_TABLE_ROW from null to 0, and even the builder cannot change the version to null (reason still unknown). So we need to avoid using static TEST_USER_TABLE_ROW, but instead create an instance for each test.

Changes

For all the boxes checked, please include additional details of the changes made in this pull request.

Testing Done

For all the boxes checked, include a detailed description of the testing done for the changes made in this pull request.

Additional Information

For all the boxes checked, include additional details of the changes made in this pull request.

jiang95-dev commented 2 months ago

Why did the pre-commit succeed but post-commit fail with the previous instance of the PR? could you capture those details in the description

The hypothesis is that pre-commit didn't capture the new commit. This is a common phenomenon of Github Action as I have encountered it several time.