search

linkedin / parseq

Asynchronous Java made easier
Apache License 2.0
1.17k stars 266 forks source link

fix mac build issue for tracevis #258

Closed aman1309 closed 4 years ago

aman1309 commented 4 years ago

Upgrading phantomjs to solve one of the build issue in testCov, fails on mac only since c++ libs used to build are different on mac. Other issues relating to installation failure:

Root cause is contextify being no longer support as it is merged native to node. Permanent fix is upgrade node and package dependencies.

for now will have use below patches(one time). I will add specific cmds to developer guide.

Refer: https://github.com/nodejs/node-gyp/issues/569 https://github.com/nodejs/node-gyp/issues/469

evanw555 commented 4 years ago

I would advise that you leave a note in the README.md file for :parseq-tracevis showing the exact commands needed to fix this. Not everyone has access to our internal development guide, plus this would make the information easier to access for anyone trying to build parseq.

aman1309 commented 4 years ago

I would advise that you leave a note in the README.md file for :parseq-tracevis showing the exact commands needed to fix this. Not everyone has access to our internal development guide, plus this would make the information easier to access for anyone trying to build parseq.

I think we should add a dev guide which can include this, will add this task in queue