linkedin / photon-ml

A scalable machine learning library on Apache Spark
Other
793 stars 185 forks source link

Fix a bug in calculating RMSE off by sqrt(2) #442

Closed yunboouyang closed 4 years ago

yunboouyang commented 4 years ago

Changes:

  1. Add correct calculation of squared loss, which will be used to compute Rooted Mean Squared Error (RMSE) by taking average and squared root.
  2. Multiply the error threshold by sqrt(2) since RMSE calculation has been changed.