search

linkedin / pyexchange

Python wrapper for Microsoft Exchange
Apache License 2.0
153 stars 98 forks source link

Fix convert_datetime_to_utc() test. #23

Closed nud closed 9 years ago

nud commented 9 years ago

The test had two flaws:

  1. The actual date was different (4/1 vs 1/1)
  2. The timezone usage was not correct (using the timezone as an argument of the datetime constructors won't work with timezones with daylight saving time according to documentation).
coveralls commented 9 years ago

Coverage Status

Coverage remained the same when pulling e981b9d52345406b5ce92c055ca0a388a8047775 on nud:fix-tz-test into 3cdb335545e4a1f722453a086a6be9193e08af79 on linkedin:master.

coveralls commented 9 years ago

Coverage Status

Coverage remained the same when pulling 10eceec6dcf5cf7c1f661651501af2a657f32186 on nud:fix-tz-test into 3cdb335545e4a1f722453a086a6be9193e08af79 on linkedin:master.

nud commented 9 years ago

FYI, this StackOverflow post has an example of the Daylight Saving Time issue.