linkedin / pyexchange

Python wrapper for Microsoft Exchange
Apache License 2.0
153 stars 98 forks source link

Fix getting a calendar event list with Exchange 14.2.247.0 … #24

Closed nud closed 9 years ago

nud commented 9 years ago

The SOAP query was returing the following error:

The request failed schema validation: The 'EndDate' attribute is
invalid - The value '2014-10-28' is invalid according to its
datatype 'http://www.w3.org/2001/XMLSchema:dateTime'; - The string
'2014-10-28' is not a valid XsdDateTime value.

The fix is simply to use the DATETIME format instead of the DATE format, as advised in the MSDN page of the CalendarView element.

http://msdn.microsoft.com/en-us/library/office/aa564515%28v=exchg.140%29.aspx

coveralls commented 9 years ago

Coverage Status

Coverage increased (+0.01%) when pulling 21d20987e8b5c17239e4214b39acad9661c36657 on nud:fix-list-events into 3cdb335545e4a1f722453a086a6be9193e08af79 on linkedin:master.

catermelon commented 9 years ago

Looks great, thank you so much for the contribution. Would you mind writing a quick test around this, so we don't regress?

coveralls commented 9 years ago

Coverage Status

Coverage increased (+0.01%) when pulling 15cff55655c66820c7307c703a1dfda5c8eb2f6f on nud:fix-list-events into 623f0af3dc06b3fb88cd29f40f2f52c9c2259ff2 on linkedin:master.

nud commented 9 years ago

Rebased on top on master, and test added.

catermelon commented 9 years ago

Awesome, thank you so much! Is this blocking you? I can put out a patch release. If not, I'll wait for a few more features to roll in.

nud commented 9 years ago

No it's not, I was implementing something else and used this as a test.

Thanks for merging.