python3 has no unicode builtin

linkedin / pyexchange

Python wrapper for Microsoft Exchange

Apache License 2.0

153 stars 98 forks source link

python3 has no unicode builtin #31

Closed eddy-geek closed 2 years ago

eddy-geek commented 9 years ago

This fixes python3 compatibility (at least for getting events in date range as per the tutorial)

coveralls commented 9 years ago

Coverage decreased (-0.08%) when pulling d126b5d0266f393de41b14f82ed8674def7a05ad on eddy-geek:master into b57555dc9113a5f5b60c914b02067335ff2a795d on linkedin:master.

coveralls commented 9 years ago

Coverage decreased (-0.08%) when pulling f8fc2e493bacd547dfba8687047c3962a918711c on eddy-geek:master into b57555dc9113a5f5b60c914b02067335ff2a795d on linkedin:master.

catermelon commented 9 years ago

Derp, I meant to get back to you and blanked. Sorry for the delay! You're right, let me enable Python 3 support on Travis so I can see what breaks across the board.

catermelon commented 9 years ago

It looks like I had some unmerged code that fixes all this - can you try the most recent commit I just made and see if it works for you? It's passing Travis now for 3.3 and 3.4.

thanks again for the work, I appreciate it.

eddy-geek commented 9 years ago

Not tested yet, but this looks to be removing all the unicode & basestring references that were causing problems. Thanks. I didn't create the PR from a feature branch so all my new commits are creeping in.

Do you want to close this one ?
Should I create a new one ? I have started basic mail support but there are no unit-tests, so not sure if you would want to merge it. Other changes should be self-explanatory.

catermelon commented 9 years ago

If you wouldn't mind starting a new one, that would be fab. And yes, please, I would need some tests before merging it, although I'm happy to look at a preliminary pull request if you want another eye for code review.