search

linkedin / pyexchange

Python wrapper for Microsoft Exchange
Apache License 2.0
153 stars 93 forks source link

Add verify_certificate parameter. #45

Closed nicklasb closed 9 years ago

nicklasb commented 9 years ago

If True, the SSL cert will be verified, if false it will not. A CA_BUNDLE path can also be provided.

It is just like the request.post works.

I propose this as I don't think it adds much to force verification, except hassle for developers that wants to try out the library.

coveralls commented 9 years ago

Coverage Status

Coverage increased (+0.01%) to 92.41% when pulling 995364920f272a288ada47a148f906a2bc481ff8 on OptimalBPM:master into 7f8c1812f4bfe4faf80fc38ef0f226061fb979bf on linkedin:master.

coveralls commented 9 years ago

Coverage Status

Coverage increased (+0.01%) to 92.41% when pulling 995364920f272a288ada47a148f906a2bc481ff8 on OptimalBPM:master into 7f8c1812f4bfe4faf80fc38ef0f226061fb979bf on linkedin:master.

coveralls commented 9 years ago

Coverage Status

Coverage increased (+0.01%) to 92.41% when pulling 995364920f272a288ada47a148f906a2bc481ff8 on OptimalBPM:master into 7f8c1812f4bfe4faf80fc38ef0f226061fb979bf on linkedin:master.

nicklasb commented 9 years ago

Hm. The 3.4 tests time out: https://travis-ci.org/linkedin/pyexchange/jobs/56710016

Actually this happened to me as well when I ran the tests locally using pytest. It timeouts at some seemingly random test. If I debug it, the tests doesn't even enter the test function. I though it was something about my installation, because I that run it using nosetest and then it worked.

But now it rather seems like an issue with pytest and python 3.4

nicklasb commented 9 years ago

Ok, so I looked at the other pull requests and it seems py.test have timed out under 3.4 on every build since january. There seem to be something generally wrong. Do with this PR what you want.

nicklasb commented 9 years ago

I just realized that nosetest also hangs, but much later on. Investigating.

nicklasb commented 9 years ago

Found nothing. I will create an issue and let those more aquainted to the testing of this project look at it instead.

got-root commented 9 years ago

I've verified that this passes all tests on python 3.4.1 when dropping httpretty to version 0.8.6.