Implemented multi-calendar support for list_events().

linkedin / pyexchange

Python wrapper for Microsoft Exchange

Apache License 2.0

152 stars 98 forks source link

Implemented multi-calendar support for list_events(). #47

Closed tbolender closed 9 years ago

tbolender commented 9 years ago

Using this awesome library I discovered that the calendar id passed to Exchange2010Service is ignored by list_events(). This pull request should fix this issue.

Since tests seems to be broken for Python 3.4 and I have only 3.4 installed, I could not run any tests.

coveralls commented 9 years ago

Coverage decreased (-0.09%) to 92.24% when pulling 80427484b88d3632c41814b1b40d71edca7aa70b on itiboi:multi-calendar-support into 1cd86fb7ed782430958259ce051338c477688253 on linkedin:master.

got-root commented 9 years ago

Thanks for the pull request! Yea unfortunately tests on Python 3.4 are broken with httpretty>0.8.6. I ran the tests using httpretty 0.8.6 and all was good.

If you've got the time, we'd appreciate it if you could write some tests around this.

Thanks again!

stephzylstra commented 9 years ago

Is it possible to re-open this pull request? I'm happy to write some tests for it when I have some spare time later (won't be for a while unfortunately) if itiboi doesn't want to. I'd find it quite useful to have this feature though.

tbolender commented 9 years ago

Feel free to do so, unfortunately I will not be able to write any tests in the near future...