search

linkedin / rest.li

Rest.li is a REST+JSON framework for building robust, scalable service architectures using dynamic discovery and simple asynchronous APIs.
rest.li
Other
2.51k stars 546 forks source link

Bug in xxHash #77

Open leventov opened 7 years ago

leventov commented 7 years ago

You use xxHash.hashInt() here: https://github.com/linkedin/rest.li/blob/35de002f4113b70bee34bb7b61b3cd9bd036eb69/d2/src/main/java/com/linkedin/d2/balancer/util/hashing/MPConsistentHashRing.java#L152

Implementation of this function contains a bug in Zero-allocation Hashing 0.4

Suggested to update to ZAH 0.7 which fixes the bug

davidhoa commented 7 years ago

Thank you for letting us know, we'll try to get to it soon. Do you have a link to the bug?

leventov commented 7 years ago

https://github.com/OpenHFT/Zero-Allocation-Hashing/commit/8a6d6a1162f8a704eb3ffc2648fdae7a39885fcd