search

linkedin / rest.li

Rest.li is a REST+JSON framework for building robust, scalable service architectures using dynamic discovery and simple asynchronous APIs.
rest.li
Other
2.51k stars 546 forks source link

Fix passing in canary distribution provider from ZKFS load balancer factory #798

Closed bohhyang closed 2 years ago

bohhyang commented 2 years ago

Previously, canary distribution provider was passed in only from last-seen load balancer factory, which causes the canary distribution provider being null for ZKFS toggling load balancer. This PR is to fix that by passing in the provider from ZKFS load balancer factory as well.

gu0keno0 commented 2 years ago

LGTM, let's consider adding some test coverage in the future? The UT coverage for these classes looks very sparse.

bohhyang commented 2 years ago

That's true. Lots of the pegasus classes have very few UT. I will create a work item to improve test coverage for our planning tomorrow. Thanks.

LGTM, let's consider adding some test coverage in the future? The UT coverage for these classes looks very sparse.

gu0keno0 commented 2 years ago

Great to hear! Thank you.