linkedin / rest.li

Rest.li is a REST+JSON framework for building robust, scalable service architectures using dynamic discovery and simple asynchronous APIs.
rest.li
Other
2.51k stars 546 forks source link

Exclude transitive Netty dependency for ZooKeeper client. #821

Closed jpstewart closed 2 years ago

jpstewart commented 2 years ago

The updated ZooKeeper client depends on Netty, but uses a newer version. Prior to that version Netty switched its netty-all Maven coordinates from being a super jar to being a pom that transitively depends on the other Netty dependencies. This makes it possible for it to bring in a conflicting version of Netty, resulting in two versions in the classpath. ZooKeeper appears fine with our current Netty version, so excluding the transitive dependencies seems the safest way to ensure no issues are caused by upgrading Netty to match the ZooKeeper version.