search

linkedin / rest.li

Rest.li is a REST+JSON framework for building robust, scalable service architectures using dynamic discovery and simple asynchronous APIs.
rest.li
Other
2.51k stars 546 forks source link

Support Unix sockets for HTTP/1 #903

Closed vigchan closed 1 year ago

vigchan commented 1 year ago

Extrapolating the code from HTTP/2 support

gu0keno0 commented 1 year ago

cc: @nizarm @jpstewart @rickzx @bohhyang This is a R2 related change for service mesh.

jpstewart commented 1 year ago

Looks like this just needs rebased and the version number and changelog updated.

vigchan commented 1 year ago

Looks like this just needs rebased and the version number and changelog updated.

Thank you so much. I think I updated the code now and hopefully there are no issues. I also have a test that keeps failing on local linux :

Gradle suite > Gradle test > com.linkedin.r2.transport.http.server.TestAsyncLockup > testAsyncLockup FAILED
    java.util.concurrent.TimeoutException at TestAsyncLockup.java:9

Do I have to worry about this?

jpstewart commented 1 year ago

Looks like this just needs rebased and the version number and changelog updated.

Thank you so much. I think I updated the code now and hopefully there are no issues. I also have a test that keeps failing on local linux :

Gradle suite > Gradle test > com.linkedin.r2.transport.http.server.TestAsyncLockup > testAsyncLockup FAILED
    java.util.concurrent.TimeoutException at TestAsyncLockup.java:9

Do I have to worry about this?

I'll see if it also happens in the github test job. There are a number of flaky async tests.

jpstewart commented 1 year ago

The tests are running fine on Github.

vigchan commented 1 year ago

The tests are running fine on Github.

Awesome! Thank you. Would you be able to merge the PR as well? I don't have the privileges to do so :)

jpstewart commented 1 year ago

The branch currently needs rebased before merging.