search

linkedin / rest.li

Rest.li is a REST+JSON framework for building robust, scalable service architectures using dynamic discovery and simple asynchronous APIs.
rest.li
Other
2.51k stars 546 forks source link

INDIS: defining next generation announcements and wiring up to existing D2 announcements #910

Closed ZoabKapoor closed 1 year ago

ZoabKapoor commented 1 year ago

This defines a next-generation service discovery announcement framework (called INDIS), separate from the Zookeeper framework, and wires it in to the existing D2 so that we double write to both systems

Testing done: unit test for ZookeeperServer modified to check that markUp and markDown calls announce and deannounce with the right parameters

ZoabKapoor commented 1 year ago

As discussed in team meeting today, we are abandoning this approach in favor of extending ZookeeperServer internally and putting custom logic in there. The only thing that needs to be done in rest.li is factoring some common logic out into a protected function. That is a different enough change that I will create a new PR for it