search

linkedin / rest.li

Rest.li is a REST+JSON framework for building robust, scalable service architectures using dynamic discovery and simple asynchronous APIs.
rest.li
Other
2.51k stars 546 forks source link

Remove reset toggling stores option in LoadBalancerClientCli to remove Java 17 incompatible code #930

Closed ZoabKapoor closed 1 year ago

ZoabKapoor commented 1 year ago

This is needed to allow us make restli compatible with Java 17. The only functionality that's removed is the ability to resetTogglingStores from the LoadBalancerClientCli, which is unused elsewhere in the codebase.

This change is needed for #929

JoeJoe1989 commented 1 year ago

LGTM. Technically, we are not planning to "upgrade restli to Java 17". Instead, we want to make restli compatible with Java 17. So probably we can rephrase the PR description to make it more explicit.

ZoabKapoor commented 1 year ago

Btw, I've created a release candidate for this so we can wc-test it: https://github.com/linkedin/rest.li/actions/runs/5895056039