Closed brycezhongqing closed 8 months ago
Please rebase the master branch for latest changes in XdsClientImpl and XdsToD2PropertiesAdaptor.
Btw, could you pls update these two dual read error level logs to warn level? It doesn't need to be error level which creates exception tickets to the owners. https://jarvis.corp.linkedin.com/codesearch/result/?name=DualReadLoadBalancer.java&path=rest.li%2Fd2%2Fsrc%2Fmain%2Fjava%2Fcom%2Flinkedin%2Fd2%2Fbalancer%2Fdualread&reponame=linkedin%2Frest.li#165
Btw, could you pls update these two dual read error level logs to warn level? It doesn't need to be error level which creates exception tickets to the owners. https://jarvis.corp.linkedin.com/codesearch/result/?name=DualReadLoadBalancer.java&path=rest.li%2Fd2%2Fsrc%2Fmain%2Fjava%2Fcom%2Flinkedin%2Fd2%2Fbalancer%2Fdualread&reponame=linkedin%2Frest.li#165
Nevermind, I'm changing this along with some other changes.
since the client requests for an non-existent cluster: /d2/clusters/NonExistentCluster. With your change, the log should show a msg like: "Received response that Cluster NonExistentCluster was removed". But it's not seen in the attached log file.
Received response that Cluster NonExistentCluster was removed
since the client requests for an non-existent cluster: /d2/clusters/NonExistentCluster. With your change, the log should show a msg like: "Received response that Cluster NonExistentCluster was removed". But it's not seen in the attached log file.
Hi, @bohhyang After rebase toki
, it works now. Updated the log.
Context
This PR mainly focus on 3 points.
log
forToggleingPublisher
when switch one typePublisher
to anotherPublisher
null guard
forINDIS
andZookeeper
response.timeout
process logic forINDIS xds
response, and also process the corner case forremoval resource
Note: When the client side receive the
removal resource from observer
that means there is no data fromINDIS
, so client could read theservice/cluster/uri properties
fromcache
directlyTest
[✅] unit test [✅] regression test in toki
Step1 :
unzip
the following files to services.zip(clear this folder before unzip)
Step2
Step3:
check key logs could found in the following log to do regression check
toki-war.log
Could get relative
clusters