Address the multiple onError calls in dual read and enhance unit test - Githubissues

linkedin / rest.li

Rest.li is a REST+JSON framework for building robust, scalable service architectures using dynamic discovery and simple asynchronous APIs.

rest.li

Other

2.51k stars 546 forks source link

Address the multiple onError calls in dual read and enhance unit test #992

Closed brycezhongqing closed 7 months ago

brycezhongqing commented 8 months ago

Summary

As the title said

Fix the multiple onError calls in dual-read null guard logic
Fefactor and add more strict unit test to make each onError method and onSuccess method will only be called one time.
Catch up more potential exception for dual-read
Try to fix some legacy unit test flaky failed issue

Test done (Unit test)

[✅] Add more unit test condition to make sure each onError and onSuccess method will only be called one time.
[✅] Add more unit test condition to make sure handleTime... method will be called when timeout