search

linkedin / school-of-sre

At LinkedIn, we are using this curriculum for onboarding our entry-level talents into the SRE role.
https://linkedin.github.io/school-of-sre/
Other
7.8k stars 715 forks source link

Improving CLI screenshots #42

Open sigonzal3 opened 3 years ago

sigonzal3 commented 3 years ago

Hello,

I was working on a similar SRE manual and recently discovered your repo. If you allow me, I would like to contribute a few ideas, so please let me know if you have any guidelines for submitting pull requests.

As first contribution, I think that changing all CLI snippets from screenshot images to asciinema would help. Here is an example: https://asciinema.org/

Let me know your thoughts.

kalyanceg commented 3 years ago

Thanks for your interest Based on eyeballing I feel asciicinema can be embedded as PNG in github pages. We should be ok as long as the content adheres to CC 4.0 license and quality standards We will come up with a cadence to handle PRs and documentation on quality standards by early next week

sumeshpremraj commented 3 years ago

@sigonzal3 can you try to create asciinema CLI snippets and open a PR? The key is to have it in PNG format so that we can embed it in the GitHub Pages static site.