Update Setting Activity Controller

linkedin / test-butler

Reliable Android Testing, at your service

Apache License 2.0

1.05k stars 92 forks source link

Closed ewolfe123 closed 6 years ago

ewolfe123 commented 6 years ago

On API 25, it seems there are versions that contain setActivityController with two parameters, instead of one. (See: https://android.googlesource.com/platform/frameworks/base/+/master/core/java/android/app/IActivityManager.aidl#175)
- Added a method to attempt both method implementations. Start with the single param, and fall back to the 2 param implementation if that fails
- The same RuntimeException will be thrown if both fail

@Kisty @drewhannay

drewhannay commented 6 years ago

ewolfe123 commented 6 years ago

Thanks @drewhannay!

Kisty commented 6 years ago

Nice find! Well done, @ewolfe123. Can we close a bunch of issues due to this change, then?

ewolfe123 commented 6 years ago

@Kisty I think only https://github.com/linkedin/test-butler/issues/66 can be closed. Will there be a Test Butler 1.3.2 that includes this fix in the near future?

drewhannay commented 6 years ago

@ewolfe123 yeah, I'll try to do a release sometime this week

drewhannay commented 6 years ago

1.3.2 has now been released :)

ewolfe123 commented 6 years ago

Awesome! Thank you both for being so responsive!