Update transport-udfs-trino.patch w.r.t trino v406

linkedin / transport

A framework for writing performant user-defined functions (UDFs) that are portable across a variety of engines including Apache Spark, Apache Hive, and Presto.

BSD 2-Clause "Simplified" License

297 stars 73 forks source link

Update transport-udfs-trino.patch w.r.t trino v406 #127

Closed weijiii closed 1 year ago

weijiii commented 1 year ago

Summary

As of version 406 the APIs for loading plugins have changed.
- Metadata#functions(List<T extends SqlFunction>) -> GlobalFunctionCatalog#addFunctions(FunctionBundle)

wmoustafa commented 1 year ago

Could you please explain why we need special code as of 406? Before 406, the required function APIs were not part of the SPI and hence we had to write code like this in Trino to make them visible like SPI APIs. Since as of 406 the required APIs are already part of the SPI, why would we need such code in the first place?

weijiii commented 1 year ago

Closing this as Transport is aiming to move to Trino SPI in the new version.