Closed yiqiangin closed 1 year ago
@yiqiangin I thought PR https://github.com/linkedin/transport/pull/147 could generate the *-trino.tar
artifact? Could you clarify the diff between PR #147 and PR#150?
Were the jars not getting published on the artifactory prior to this PR?
@yiqiangin I thought PR #147 could generate the
*-trino.tar
artifact? Could you clarify the diff between PR #147 and PR#150? Were the jars not getting published on the artifactory prior to this PR? @aastha25 There are 4 build outputs for Trino including*-trino.tar
,*-trino.zip
,*-trino-thin.jar
and*-trino-dist-thin.jar
.*-trino.tar
and*-trino.zip
are built by two distribution tasks inDistributionPackaging
and placed underdistribution
folder;*-trino-thin.jar
and*-trino-dist-thin.jar
are built by two Jar tasks inThinJarPackaging
andDistributionPackaging
respectively and placed underlibs
folder. PR #147 only adds the Jar tasks to build*-trino-thin.jar
and*-trino-dist-thin.jar
intoproject.getArtifacts()
explicitly, therefore only*-trino-thin.jar
and*-trino-dist-thin.jar
are published as artifacts, not*-trino.tar
and*-trino.zip
. However, Trino server requires the artifacts of*-trino.tar
,*-trino.zip
and*-trino-thin.jar
, not*-trino-dist-thin.jar
. The difference between PR #150 and PR #147 is adding two distribution tasks inDistributionPackaging
to build*-trino.tar
and*-trino.zip
intoproject.getArtifacts()
and no longer adding the Jar task to build*-trino-dist-thin.jar
intoproject.getArtifacts()
. Yes,*-trino.tar
and*-trino.zip
are not published as artifacts before this PR.
Code Change
project.getArtifacts()
explicitly if the build output needs to be published as an artifact. Therefore inDistributionPackaging.configurePackagingTasks
, the task to generate*-trino.tar
(*-trino.zip) in as a distribution package are added into
project.getArtifacts()` explicitly*-trino-dist-thin.jar
out ofproject.getArtifacts()
Test cd transport ./gradlew clean build
// in a consumer UDF MP ./gradlew clean build mint release
The resulted artifact list in the file of buildspec.json are as follows: