Fix missing arguments nullability in FunctionMetadata

linkedin / transport

A framework for writing performant user-defined functions (UDFs) that are portable across a variety of engines including Apache Spark, Apache Hive, and Presto.

BSD 2-Clause "Simplified" License

291 stars 72 forks source link

Fix missing arguments nullability in FunctionMetadata #151

Closed weijiii closed 1 year ago

weijiii commented 1 year ago

Summary

Should fix the issues in #149
Related concern was raised here
Trino engine does not invoke function when non-nullable arguments receive null value; this is determined by FunctionMetadata#functionNullability
FunctionMetadata#argumentNullability expects Boolean object
Revert changes in TestFileLookUp, since Trino actually throws NullPointerException in this case

weijiii commented 1 year ago

@yiqiangin Can you please check if the other isTrinoTest usage are needed and request changes? Thanks.

yiqiangin commented 1 year ago

@yiqiangin Can you please check if the other isTrinoTest usage are needed and request changes? Thanks.

Other usages of isTrinoTest are still needed as they are not related to null argument. Also With this code change, all tests in standard-udf-userinterfacelookup and standard-udfs-dali-udfs can pass now.