linkedin / transport

A framework for writing performant user-defined functions (UDFs) that are portable across a variety of engines including Apache Spark, Apache Hive, and Presto.
BSD 2-Clause "Simplified" License
297 stars 73 forks source link

Produce two artifacts in Spark for scala_2.11 and scala_2.12 #85

Closed HotSushi closed 3 years ago

HotSushi commented 3 years ago

Changes that this PR brings:

Outcome of this PR is that:

Testing can be done:

How it works? Scala plugin's compileScala task automatically configures the classpath required to build scala code. It does so by looking for "scala-library.jar" in all dependencies declared in the compile classpath. If a module declares dependency on all scala_2.12 artifacts, the "scala-library.jar" that gets inferred is for scala_2.12. Similarly for building scala_2.11 artifact, all dependencies should be built against scala_2.11. In this PR we create separate modules for scala_2.11 and scala_2.12 with appropriately versioned dependencies.

cc: @shardulm94 @wmoustafa

wmoustafa commented 3 years ago

It seems travis-ci validation did not work. Could you double check by building the examples module again locally before merging?