linkedin / venice

Venice, Derived Data Platform for Planet-Scale Workloads.
https://venicedb.org
BSD 2-Clause "Simplified" License
487 stars 84 forks source link

[controller] Stop writing writing ready-to-serve instances info in meta system store #1228

Closed sushantmane closed 3 weeks ago

sushantmane commented 3 weeks ago

Stop writing writing ready-to-serve instances info in meta system store

When materializing the meta store, we produce a snapshot of readyToServeInstances for all user store versions. If a version is in an ERROR state, its Helix resources may not exist. Attempting to check these resources can throw exceptions, potentially causing the addVersion process to fail.

The info about RTS instances in meta store was required in the past but it is no
longer used by any clients so it's safe to stop writing this into meta system store.

How was this PR tested?

Does this PR introduce any user-facing changes?

sushantmane commented 3 weeks ago

Thanks for the review, @sixpluszero!