linkedin / venice

Venice, Derived Data Platform for Planet-Scale Workloads.
https://venicedb.org
BSD 2-Clause "Simplified" License
487 stars 84 forks source link

[controller] Set min RF on controllers and storage clusters to RF - 1 with a floor of 1 #1242

Closed kvargha closed 2 weeks ago

kvargha commented 2 weeks ago

Summary, imperative, start upper case, don't end with a period

Currently, the min replication factor (RF) for controllers is equal to replication factor. During a deployment, the number of instances could go below what is set to RF, which would cause a rebalance failure when using Waged.

To prevent this, we will be setting min RF = max(RF - 1, 1). This will be applied to the storage clusters too.

How was this PR tested?

CI

Does this PR introduce any user-facing changes?