Consider use of CDN - Githubissues

linkedpipes / dcat-ap-viewer

Viewer of DCAT-AP 2.0.1 compatible dataset metadata

MIT License

7 stars 6 forks source link

Consider use of CDN #110

Closed skodapetr closed 4 years ago

skodapetr commented 6 years ago

https://cdnjs.cloudflare.com/ajax/libs/react/16.4.2/cjs/react.production.min.js
https://cdnjs.cloudflare.com/ajax/libs/react-dom/16.4.2/cjs/react-dom.production.min.js
https://cdn.jsdelivr.net/npm/es6-promise@4/dist/es6-promise.min.js and others ..

akuckartz commented 6 years ago

Why?

skodapetr commented 6 years ago

It would decrease the size of the bundle (yep, it's not that important at the end). Of course, the benefit strongly depends on the overall usage of CDNs nowadays, especially by React application.

It would not bring a dependency on being online as even now we are using CDN for Bootstrap.

However, it's for consideration so any ideas/arguments are welcomed here.

skodapetr commented 4 years ago

At the end, we decide not to do this, but rather focus on minimization of the bundle size in #112.