linkedpipes / dcat-ap-viewer

Viewer of DCAT-AP 2.0.1 compatible dataset metadata
MIT License
6 stars 6 forks source link

How to create LKOD profile based on NKOD profile #213

Closed jakubklimek closed 3 years ago

jakubklimek commented 4 years ago

I understand that there is now a profile support, so that we could have an "LKOD" profile.

However, it seems that almost everything including translations, etc. is in the nkod profile. For the LKOD profile, all I need to change is header.jsx and footer.jsx and I do not want to copy everything in nkod profile for this.

Is there a way to base a profile on another, changing only something like this?

skodapetr commented 3 years ago

Yes, there is. The main idea is that developer of a profile should use registry to register components. During the render function the components to render are obtained from the registry. This should allow develop to import from another profile and just provide (register) custom implementation of components that should be changed.

However it is not completely ready yet, but should be soon. In fact it can be a nice proof of concept to implement LKOD profile + create a description of the process in the Wiki.

jakubklimek commented 3 years ago

In that case I think that the LKOD profile should be the base, and NKOD the specialization.

skodapetr commented 3 years ago

It is implemented in branch feature/refactoring.