linkedpipes / discovery-legacy

The LinkedPipes Discovery implementation here is deprecated and replaced by a new one.
1 stars 3 forks source link

Transformer group reduces number of pipelines too much #13

Closed jakubklimek closed 6 years ago

jakubklimek commented 6 years ago

When transformer groups are present, the number of discovered pipelines is reduced too much.

https://discovery.linkedpipes.com/resource/discovery/timeline-test-1/config and https://discovery.linkedpipes.com/resource/discovery/timeline-test-1g/config are the same discovery configurations, except 1g has a transformer group with one member. The results should be identical, however, the discovery without a group finds 29 pipelines, the discovery with the group finds 16 pipelines.

jirihelmich commented 6 years ago

Iteration 1 finds 14 pipeline fragments, all ending with the transformer. As per your request, all those pipelines are groupped and replaced by one pipeline, containing all matching transformers from that group (the same one).

So if the number of transformers from group that matched is 1, I should not follow this logic?

jakubklimek commented 6 years ago

I don't think that is the problem. The problem is this: Without groups, I find a pipeline which contains the transformer: image With groups, this pipeline is not found and IMHO should be: image