Open jindrichmynarz opened 7 years ago
I looked into that linked document and I was unable to find an explanation for the above-mentioned parameters. Hence, I asked this question.
OK. The phrasing is unfortunate though. How about using these labels?
!lodcloud.nolinks
)lodcloud.unconnected = !this && !lodcloud.nolinks
)Even if we keep the original labels, I think the state of the switch should be clarified by changing its label as other LP-ETL components do.
In this case, I would prefer sticking to the original document and not complicate the switch logic. It is confusing in the original document and it is not up to us to guess or interpret what the authors meant.
Sure. Then I think we should just make the label change when the switch is on to indicate what is its state (and to be consistent with the other LP-ETL components).
Other components are not consistent in this. At first we thought that it would be cool, but then it is not clear what the other state does until switched.
So what would the two labels be like? I would maybe omit "external" but otherwise leave them as they are.
Just drop the "No" for the other state.
The DCAT-AP to datahub.io component has two parameters that seem nearly duplicate:
Do we need both? If that is the case, what is the difference between them? What is their meaning? When they are switched off, does it mean that the dataset has no links? Other boolean parameters in LP-ETL component change their labels when they are toggled, but not this one. Changing the label might make the parameters clearer.
Tested using the develop version e075246dce28cfab21b0535b7d0691515b659339.