linkerd / linkerd-examples

Examples of how to configure and run linkerd
https://linkerd.io
Apache License 2.0
432 stars 221 forks source link

ThirdPartyResources to be removed in Kubernetes 1.8 #183

Closed krak3n closed 5 years ago

krak3n commented 7 years ago

As https://kubernetes.io/docs/tasks/access-kubernetes-api/extend-api-third-party-resource/ describes ThirdPartyResource will be removed in 1.8.

ThirdPartyResource is deprecated as of Kubernetes 1.7 and has been removed in version 1.8 in accordance with the deprecation policy for beta features.

To avoid losing data stored in ThirdPartyResources, you must migrate to CustomResourceDefinition before upgrading to Kubernetes 1.8 or higher.

I guess the examples need to be updated to use CustomResourceDefinition - I'm having a go at getting stuff working using CustomResourceDefinition so we'll see

esbie commented 7 years ago

Yep we have seen that notice as part of 1.8, thank you for filing this issue! Namerd will need to be updated to support CustomResourceDefinitions before the examples are updated.

krak3n commented 7 years ago

Ah ok thank you @esbie I did have a go at using CustomResourceDefinitions but it didn't work so that would be why :smile:

siggy commented 7 years ago

replace ThirdPartyResource from: https://github.com/linkerd/linkerd-examples/blob/master/k8s-daemonset/k8s/namerd.yml#L1

with CustomResourceDefinition: https://github.com/linkerd/linkerd/blob/master/namerd/examples/k8s/3rdparty.yaml

krak3n commented 7 years ago

Thanks guys :+1:

siggy commented 6 years ago

I'm going to leave this open until we've updated the namerd.yml example, or provided a separate k8s 1.8 example.

dadjeibaah commented 5 years ago

New namerd yaml has been added https://github.com/linkerd/linkerd-examples/blob/master/k8s-daemonset/k8s/namerd.yml