search

linkerd / linkerd-examples

Examples of how to configure and run linkerd
https://linkerd.io
Apache License 2.0
431 stars 221 forks source link

Enhanced logging of stats reporter #237

Closed farquet closed 6 years ago

farquet commented 6 years ago

Added --warmup-time and --report-interval which both default to the previously hardcoded values.

javawithjiva commented 6 years ago

LGTM

farquet commented 6 years ago

I did the suggested changes. Thanks for the feedback.

wmorgan commented 6 years ago

Thanks @farquet, and welcome to the project!

farquet commented 6 years ago

Thanks ! I see on gcr.io that the latest image for reporter is a week old. Would you be ok to push the latest version including this little change ?

dadjeibaah commented 6 years ago

@farquet latest image has just been pushed. You should be able to pull your new changes.

farquet commented 6 years ago

Awesome. Thanks !