linkerd / linkerd-examples

Examples of how to configure and run linkerd
https://linkerd.io
Apache License 2.0
432 stars 221 forks source link

Adding two CloudFormation templates for setting up the Linkerd #240

Closed nathanpeck closed 6 years ago

nathanpeck commented 6 years ago

This adds two new CloudFormation templates that set up all the LinkerD resources automatically, without needing to have many manual steps as in the original getting started guide for ECS. Accompanying PR for https://github.com/linkerd/website/pull/34

nathanpeck commented 6 years ago

Great feedback. I do like the idea of using the SSH tunnel to access those internal ports for the dashboard and viz. I'll modify the template to accept an SSH key name from the user's account when launching the cluster and include instructions for how to SSH tunnel to make a request.

Do you think it makes sense to send the request to the linkerd proxy via SSH tunnel as well? I did like the simplicity in the original doc of being able to just send a curl request to port 4140 on any machine, although in a realistic prod deployment I'm not sure if its best practice to open your port 4140 directly to the world.

siggy commented 6 years ago

@nathanpeck Good question. I think if we're already going to ask the user for their ssh key name, and tunnel for linkerd-viz on 3000, it's fine to also ask them to tunnel to port 4140.

nathanpeck commented 6 years ago

Cool! I'm working on these changes today. I'm also going ahead and upgrading the Consul version to the latest, because I noticed that the Consul in the original getting started guide was kind of old and popping up an upgrade warning when you navigate to the Consul admin UI

nathanpeck commented 6 years ago

Updates:

nathanpeck commented 6 years ago

Very nice! All updated according to recommendation!

nathanpeck commented 6 years ago

Thanks!