search

linkerd / linkerd-examples

Examples of how to configure and run linkerd
https://linkerd.io
Apache License 2.0
431 stars 220 forks source link

Local l5d discovery issue in k8s-daemonset example #45

Open sevein opened 7 years ago

sevein commented 7 years ago

When I tried to deploy k8s-daemonset/k8s/hello-world-1_4.yml in my minikube I ran into an issue where the value given to spec.nodeName (minikube) wasn't resolvable by kube-dns, causing an exception in hello.py. I'm not sure why this wasn't a problem in other k8s deployments. In minikube and k8s 1.4, hostIP.sh or similar approach looking up status.hostIP may still be necessary.

There is a proposal in kubernetes to improve node-local service discovery when using DaemonSets that could solve this issue.

adleong commented 7 years ago

Thanks for the report! Bummer that nodeName doesn't work in minikube.

klingerf commented 7 years ago

I ran into this issue today too, and verified that it's still a problem with the latest version of Minikube. I added some extra information to our README to hopefully help clarify -- #109.