linkerd / linkerd-viz

Top-line service metrics dashboard for Linkerd 1.
Apache License 2.0
111 stars 32 forks source link

Consul startup doc error #38

Closed dlaidlaw closed 7 years ago

dlaidlaw commented 7 years ago

The Readme for the Consul Deploy says to start Consul with docker in host networking mode, then start the linkerd-vis docker container without host networking mode. This will not work because the linkerd-vis configuration for consul is set to use localhost:8500. The localhost will not work unless the linkerd-vis container is also run in host networking mode.

siggy commented 7 years ago

Nice catch @dlaidlaw, fix is up: #39.