search

linkerd / linkerd2-conformance

A Conformance Validation tool for Linkerd 2.X
https://linkerd.io/
Apache License 2.0
1 stars 2 forks source link

CI: add Github workflow for KinD testing and static checks #11

Closed mayankshah1607 closed 4 years ago

mayankshah1607 commented 4 years ago

Fixes https://github.com/linkerd/linkerd2-conformance/issues/4

Signed-off-by: Mayank Shah mayankshah1614@gmail.com

mayankshah1607 commented 4 years ago

Also, it looks like the linter is failing due to linting errors in the code. I should probably make a refactor that fixes all of this along with test flakiness and assertions once this is merged!

Pothulapati commented 4 years ago

@mayankshah1607 Yep, just saw this. Can you update the code here itself to fix the linters, so that we don't have checks failing after this is merged? Also, helps us keeping the refactor PR a separate one!

Pothulapati commented 4 years ago

One last Nit, I see a weird ./target/bin/goimports- which can be deleted? :thinking:

mayankshah1607 commented 4 years ago

One last Nit, I see a weird ./target/bin/goimports- which can be deleted

Yep, did not notice that. Deleted, and added to .gitignore :)

Can you update the code here itself to fix the linters

Sure! :)