linkerd / linkerd2-conformance

A Conformance Validation tool for Linkerd 2.X
https://linkerd.io/
Apache License 2.0
1 stars 2 forks source link

Omit flaky `linkerd inject --manual` output validation #23

Closed mayankshah1607 closed 4 years ago

mayankshah1607 commented 4 years ago

This PR temporarily mutes the text validation part of linkerd inject --manual test case. This has to be done because currently manual injection is tested by validating the text output against a predefined .golden file that holds the expected output. This approach may often fail because linkerd inject --manual may have a different text output depending on the version of Linkerd used (mentioned in the config.yaml; by default its the latest edge). Until we figure out a better way to validate the output, this part of the test case needs to be omitted to prevent flakiness.

Signed-off-by: Mayank Shah mayankshah1614@gmail.com