linkerd / linkerd2

Ultralight, security-first service mesh for Kubernetes. Main repo for Linkerd 2.x.
https://linkerd.io
Apache License 2.0
10.49k stars 1.27k forks source link

Refactor ES addition logic in Destination #12625

Closed alpeb closed 1 month ago

alpeb commented 1 month ago

This is a second take on #12427, which avoided a theoretical/correctness issue around overwritting new ES addresses with stale data.

We had to revert that in #12589 because the change introduced a bug, by returning early when the ES had no addresses and failed to properly initiallize addesses for the portPublisher.

This just removes the early return.