feat!: Add config to disable proxy /shutdown admin endpoint

linkerd / linkerd2

Ultralight, security-first service mesh for Kubernetes. Main repo for Linkerd 2.x.

https://linkerd.io

Apache License 2.0

10.48k stars 1.27k forks source link

feat!: Add config to disable proxy /shutdown admin endpoint #12705

Closed adleong closed 2 weeks ago

adleong commented 3 weeks ago

We add a proxy.enableShutdownEndpoint Helm value and corresponding config.linkerd.io/enableShutdownEndpoint workload annotation for configuring the proxy's /shutdown admin endpoint. These configs work by setting the LINKERD2_PROXY_SHUTDOWN_ENDPOINT_ENABLED env var on the proxy.

Depends on https://github.com/linkerd/linkerd2-proxy/pull/3014

KenVanGrinsven commented 1 week ago

Why isn't this documented as a breaking change in the release notes, since we've changed a default value here? Also, I expected the documentation for graceful pod shutdown to be updated with this change, mentioning that this endpoint is turned off by default.

kflynn commented 4 days ago

@KenVanGrinsven Ouch, thanks for pointing that out! I've edited the release notes to cover that, and will be updating the docs shortly. Sorry for the misstep, and thanks for pointing it out!