Default values for linkerd-init (resources allocated) are not always the right fit. We offer default values to ensure proxy-init does not get in the way of QOS Guaranteed (linkerd-init resource limits and requests cannot be configured in any other way).
Instead of using default values that can be overridden, we can re-use the proxy's configuration values. For the pod to be QOS Guaranteed, the values for the proxy have to be set any way. If we re-use the same values for proxy-init we can ensure we'll always request the same amount of CPU and memory as needed.
linkerd-init now defaults to the proxy's values
when the proxy has an annotation configuration for resource requests, it also impacts linkerd-init
Helm chart and docs have been updated to reflect the missing values.
tests now no longer use ProxyInit.Resources
UPGRADE NOTE:
Deprecates proxyInit.resources field in the Helm values.
It will be a no-op if specified (no hard failures)
Closes #11320
Notes to reviewers:
You can test by building and then installing Linkerd:
Default values for
linkerd-init
(resources allocated) are not always the right fit. We offer default values to ensure proxy-init does not get in the way of QOS Guaranteed (linkerd-init
resource limits and requests cannot be configured in any other way).Instead of using default values that can be overridden, we can re-use the proxy's configuration values. For the pod to be QOS Guaranteed, the values for the proxy have to be set any way. If we re-use the same values for proxy-init we can ensure we'll always request the same amount of CPU and memory as needed.
linkerd-init
now defaults to the proxy's valueslinkerd-init
ProxyInit.Resources
UPGRADE NOTE:
proxyInit.resources
field in the Helm values.Closes #11320
Notes to reviewers:
You can test by building and then installing Linkerd:
Test cases
We expect to see:
Now, if we update and set proxy resources we should see other deployments inherit it:
We expect:
10m
cpu requests and limits for proxy and proxy-initAnd finally, we can override this with an annotation. We expect to see: