linkerd / website

Source code for the linkerd.io website
Apache License 2.0
44 stars 213 forks source link

Update ECS getting started page to use new daemon service support in ECS #6

Closed nathanpeck closed 6 years ago

nathanpeck commented 6 years ago

The ECS getting started guide says:

 Note that linkerd, consul-agent, and consul-registrator run on every ECS node.
 As of the writing of this guide, the ECS scheduler does not explicitly support this.
 Instead, we use an AWS Launch Configuration to bootstrap every ECS node with
 these three foundational services. We still boot these foundational services via an
 aws ecs start-task command, so they will be visible as running ECS containers.

ECS now supports daemon services via the DAEMON scheduling strategy: https://docs.aws.amazon.com/AmazonECS/latest/developerguide/ecs_services.html#service_scheduler

These docs can be updated to no longer use the launch configuration and instead use a daemon service. If I get time I'll take a stab at an initial pass to update them as it will make the linkerd daemon deployment much more stable and safe.

grampelberg commented 6 years ago

@nathanpeck this sounds like an awesome update. As I know absolutely nothing about ECS, would you mind taking a pass? A PR would be super, duper fantastic.

nathanpeck commented 6 years ago

Awesome will do!

nathanpeck commented 6 years ago

The first take on an update to the ECS getting started is up at https://containersonaws.com/architecture/linkerd-1x-consul-service-mesh/

Some notable changes:

I'd be interested in knowing which if any of these changes you'd like to pull into the official docs. At a minimum I think the usage of ECS daemons instead of manual RunTask, and the usage of a task role instead of an EC2 role should be pulled in.

grampelberg commented 6 years ago

In my opinion, I'd love all of that in the official docs. It looks fantastic!

wmorgan commented 6 years ago

Agreed, I would happily see all of those changes in the docs.

nathanpeck commented 6 years ago

The following PR's address this issue:

grampelberg commented 6 years ago

@nathanpeck can we close this out now?

nathanpeck commented 6 years ago

Yep! Thanks a lot everyone!

grampelberg commented 6 years ago

Thank you! Awesome doc =)