linkml / linkml-model

Link Modeling Language (LinkML) model
https://linkml.github.io/linkml-model/docs/
34 stars 16 forks source link

fixed broken links in specification #132

Closed vincentvialard closed 1 year ago

vincentvialard commented 1 year ago

replaced dead links to <item>.md files with links to corresponding page https://w3id.org/linkml/<item>

sierra-moxon commented 1 year ago

Hi @vincentvialard - I cloned your fork, checked out your branch and then built the docs locally according to this recipe:

poetry update linkml

# get the rest of the doc 
make gen-project

# overwrite the docs directly
make gen-doc

# copy over the specification docs manually for now
mkdir target/docs/specification
cp -R specification/*/*md target/docs/specification/

poetry run mkdocs build --dirty
make serve

and when I look at the docs locally, the links are still broken? Did you have more luck?

vincentvialard commented 1 year ago

Thanks for the recipe, I did not know how to check the results of my changes. I had to tweak it a bit, but got it working.

The links to sibling pages were not correct. Now everything works fine for me.

Here is the exact recipe I used:

poetry update linkml
make gen-project
make gendoc
cp -R specification/ target/docs/
poetry run mkdocs build --dirty
make serve
vincentvialard commented 1 year ago

Most of the problems solved by this PR are solved in the current version. Closing and reopening a new one for the remaining issues.