search

linkml / linkml-project-cookiecutter

A cookiecutter for linkml projects. An equivalent of `linkml-ws new project-name`.
Creative Commons Zero v1.0 Universal
14 stars 16 forks source link

refactor(workflows): updates for custom github org #102

Open noelmcloughlin opened 4 months ago

noelmcloughlin commented 4 months ago

This PR is some updates to github workflows which should be non-breaking.

I'm running workflow steps inside a container and needed some adjustments.

Also gh-pages branch is not configured in my github organization so documenting alternative steps.

turbomam commented 4 months ago

Thanks @noelmcloughlin

What's the motivation for using

python3 -m pip install --user pipx and python3 -m pipx instead of poetry (or pipx directly)?

I have pipx and poetry installed as system dependencies, so I always thought of them as soft requirements for doing LinkML development.

dalito commented 4 months ago

The reason is that pipx is not in his container in contrast to the github action containers which have it by default. Maybe the changes to run without pages and without pipx can be put into a customization md file instead? Then the action file could stay short.

noelmcloughlin commented 4 months ago

Hi, My environment is heavily regulated. GitHub Runners only have system python-3.6 so I need to use a container which has multiple python in /bin directory. The following throws error for me:

      - name: Set up Python.
        uses: actions/setup-python@v4
        with:
          python-version: 3.9

So in my PR I explicitly call python3 -m pip just to be explicit. And in real life I actually invoke python3.11 -m pip since that is what I'm using inside container.

Let me do some further thinking on this - maybe my PR needs more work.