search

linkml / linkml-project-cookiecutter

A cookiecutter for linkml projects. An equivalent of `linkml-ws new project-name`.
Creative Commons Zero v1.0 Universal
14 stars 16 forks source link

fix(setup): fixes for make setup #34

Closed noelmcloughlin closed 1 year ago

noelmcloughlin commented 1 year ago

This PR seems to fix the following issues with make setup procedure:

  1. Makefile bad substitution (and remove some trailing white spaces)
  2. https://github.com/linkml/linkml-project-cookiecutter/issues/33 
    
(baselink-py3.10) ~/git/hub/projects/baselink/baselink$ make setup
./utils/get-value.sh: 4: Bad substitution
./utils/get-value.sh: 4: Bad substitution
poetry install

This does not appear to be a Git project

noelmcloughlin commented 1 year ago

Unfortunately my PR solves Step 4 but breaks Step 8 due to nested .git/ directories.

Step 4: Run git init in directory ./linkml-projects/ solves #33 OK Step 5: OK Step 6: OK Step 7: OK Step 8: NOK

cd  ./linkml-projects/my-awesome-schema/
git remote add origin https://github.com/my-user-or-organization/my-awesome-schema.git
git branch -M main
git push -u origin main

error: 'main/' does not have a commit checked out

The solution for Step 8 is unsatisfying but effective!!

rm -fr ../.git               #  revert what we done for step 4 = fix the error above
git remote add origin https://github.com/my-user-or-organization/my-awesome-schema.git
git branch -M main
git push -u origin main

Suggestions welcome!

cmungall commented 1 year ago

I think the changes to the Makefile are good - maybe separate these out?

As for the README instructions, I think we need to revisit these as a whole as getting setup is still more complex than it needs to be

noelmcloughlin commented 1 year ago

Closed for now: https://github.com/linkml/linkml-project-cookiecutter/pull/36