Fetch tags for poetry-dynamic-versioning

linkml / linkml-project-cookiecutter

A cookiecutter for linkml projects. An equivalent of `linkml-ws new project-name`.

Creative Commons Zero v1.0 Universal

14 stars 16 forks source link

Fetch tags for poetry-dynamic-versioning #88

Closed dalito closed 6 months ago

dalito commented 6 months ago

Closes #76

pkalita-lbl commented 6 months ago

While it might not be a bad safeguard I don't believe a full checkout is strictly necessary. You can see that the PyPI publish workflow in the main linkml repo doesn't do that. When it runs there is a warning because of the shallow checkout (the Dunamai library may just be being overly cautious) but does nevertheless produce the correct version number.

dalito commented 6 months ago

Ah, OK. I mainly made the PR because I misunderstood the issue description initially. So I leave it up to you. We can just close this.

Interestingly, the doc-build also does a full checkout (in deploy-docs.yaml).

pkalita-lbl commented 6 months ago

Not quite sure off the top of my head why the deploy-docs workflow does a full checkout. I might look into that and see if it's really necessary. In the meantime I think I'm going to close this PR as suggested.