Open joshmoore opened 1 year ago
Hi @joshmoore - sorry this took so long to review; I'd like to take a look and get it resolved. Unfortunately, I don't have permission here to resolve the conflicts. (thank you for giving maintainers access to the PR - I am not sure why I can't resolve the conflicts with that permission but the button is unavailable to me). Can you resolve the conflicts here? Then I can walk through and get the tests passing. Thanks in advance!
@sierra-moxon, no worries (though odd): done.
It looks like this has gone stale while waiting to be reviewed
Please let me know if there's something needed from my side.
This primarily adds the test cases mentioned under https://github.com/linkml/linkml/issues/947. In debugging, there were a number of locations where an explicit
None
check helped with determining what was wrong which I've included. Please let me know if those should be separated out.Note: this is currently failing both for all attributes as well as all slots with: