search

linkml / linkml-runtime

Runtime support for linkml generated models
https://linkml.io/linkml/
Creative Commons Zero v1.0 Universal
24 stars 23 forks source link

csv testing and bug fixes #205

Open joshmoore opened 1 year ago

joshmoore commented 1 year ago

This primarily adds the test cases mentioned under https://github.com/linkml/linkml/issues/947. In debugging, there were a number of locations where an explicit None check helped with determining what was wrong which I've included. Please let me know if those should be separated out.

Note: this is currently failing both for all attributes as well as all slots with:

>           self.objectB = Object(**as_dict(self.objectB))
E           TypeError: tests.test_loaders_dumpers.models.table.Object() argument after ** must be a mapping, not str
sierra-moxon commented 1 year ago

Hi @joshmoore - sorry this took so long to review; I'd like to take a look and get it resolved. Unfortunately, I don't have permission here to resolve the conflicts. (thank you for giving maintainers access to the PR - I am not sure why I can't resolve the conflicts with that permission but the button is unavailable to me). Can you resolve the conflicts here? Then I can walk through and get the tests passing. Thanks in advance!

joshmoore commented 1 year ago

@sierra-moxon, no worries (though odd): done.

nlharris commented 3 months ago

It looks like this has gone stale while waiting to be reviewed

joshmoore commented 3 months ago

Please let me know if there's something needed from my side.