search

linkml / linkml-runtime

Runtime support for linkml generated models
https://linkml.io/linkml/
Creative Commons Zero v1.0 Universal
25 stars 23 forks source link

Allow for non-CURIE identifiers to be encoded. #223

Closed cmungall closed 1 year ago

cmungall commented 1 year ago

Fixes https://github.com/linkml/linkml/issues/576

This allows for controlling the bahvior of URI encoding when a string identifier slot is used. Addition of a percent_encoded annotation forces encoding plus the base URI

codecov-commenter commented 1 year ago

Codecov Report

Merging #223 (7a096ab) into main (f0cf680) will increase coverage by 0.22%. The diff coverage is 97.29%.

@@            Coverage Diff             @@
##             main     #223      +/-   ##
==========================================
+ Coverage   63.00%   63.22%   +0.22%     
==========================================
  Files          52       52              
  Lines        6038     6066      +28     
  Branches     1628     1638      +10     
==========================================
+ Hits         3804     3835      +31     
+ Misses       1779     1777       -2     
+ Partials      455      454       -1
Impacted Files Coverage Δ
linkml_runtime/utils/schemaview.py 86.38% <92.30%> (+0.06%) :arrow_up:
linkml_runtime/dumpers/rdflib_dumper.py 97.84% <100.00%> (+0.23%) :arrow_up:
linkml_runtime/loaders/rdflib_loader.py 89.72% <100.00%> (+1.59%) :arrow_up:
linkml_runtime/utils/yamlutils.py 75.63% <0.00%> (+0.84%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

joshmoore commented 1 year ago

@cmungall: aware of @hsolbrig's comments in https://github.com/linkml/linkml/issues/576, do you see this as being ready to be adopted or should I hold off for it to show up in the public docs?