linkml / linkml-runtime

Runtime support for linkml generated models
https://linkml.io/linkml/
Creative Commons Zero v1.0 Universal
24 stars 23 forks source link

Simplifying schemaview implementation of induced attributes. #225

Closed cmungall closed 1 year ago

cmungall commented 1 year ago

The algorithm for induced slots for (c,s) is now:

First, determine if s is an attribute on c or an ancestor;

apply slot_usage from ancestors as before

codecov-commenter commented 1 year ago

Codecov Report

Merging #225 (c1c84db) into main (f0cf680) will increase coverage by 0.20%. The diff coverage is 96.42%.

@@            Coverage Diff             @@
##             main     #225      +/-   ##
==========================================
+ Coverage   63.00%   63.20%   +0.20%     
==========================================
  Files          52       52              
  Lines        6038     6064      +26     
  Branches     1628     1637       +9     
==========================================
+ Hits         3804     3833      +29     
+ Misses       1779     1777       -2     
+ Partials      455      454       -1     
Impacted Files Coverage Δ
linkml_runtime/utils/schemaview.py 86.35% <93.75%> (+0.02%) :arrow_up:
linkml_runtime/dumpers/rdflib_dumper.py 97.84% <100.00%> (+0.23%) :arrow_up:
linkml_runtime/loaders/rdflib_loader.py 89.72% <100.00%> (+1.59%) :arrow_up:
linkml_runtime/utils/yamlutils.py 75.63% <0.00%> (+0.84%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.