Closed hsolbrig closed 10 months ago
Merging #236 (f37f1af) into main (b992fe0) will increase coverage by
0.46%
. The diff coverage is79.24%
.
@@ Coverage Diff @@
## main #236 +/- ##
==========================================
+ Coverage 63.54% 64.00% +0.46%
==========================================
Files 53 53
Lines 6117 6154 +37
Branches 1650 1661 +11
==========================================
+ Hits 3887 3939 +52
+ Misses 1774 1731 -43
- Partials 456 484 +28
Impacted Files | Coverage Δ | |
---|---|---|
linkml_runtime/utils/yamlutils.py | 76.63% <56.25%> (-1.52%) |
:arrow_down: |
linkml_runtime/loaders/loader_root.py | 70.21% <75.00%> (+3.54%) |
:arrow_up: |
linkml_runtime/utils/schemaview.py | 86.41% <86.95%> (+0.01%) |
:arrow_up: |
linkml_runtime/utils/namespaces.py | 73.05% <100.00%> (+2.16%) |
:arrow_up: |
linkml_runtime/linkml_model/meta.py | 53.63% <0.00%> (+0.84%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
The conflicts in this PR with main are very difficult to resolve (I got most of them resolved, but the poetry.lock file is messy). Should we recreate this change set on a more recent version of main?
Let’s just close this
On Fri, Oct 13, 2023 at 3:35 PM Sierra Moxon @.***> wrote:
The conflicts in this PR with main are very difficult to resolve (I got most of them resolved, but the poetry.lock file is messy). Should we recreate this change set on a more recent version of main?
— Reply to this email directly, view it on GitHub https://github.com/linkml/linkml-runtime/pull/236#issuecomment-1762320751, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAMMONWGO24LKDO6F4KYT3X7G63FANCNFSM6AAAAAATICUFLY . You are receiving this because your review was requested.Message ID: @.***>
Note that the test code in test_loaders_dumpers/test_loaders_dumpers.py/test_load_from_list changed. Needs discussion