linkml / linkml-runtime

Runtime support for linkml generated models
https://linkml.io/linkml/
Creative Commons Zero v1.0 Universal
24 stars 23 forks source link

SchemaView initialization from a PosixPath #249

Closed joeflack4 closed 1 year ago

joeflack4 commented 1 year ago

Updates

- Update: UX: SchemaView: Creating a new instance now accepts a PosixPath rather than just a string representation of a file path.
codecov-commenter commented 1 year ago

Codecov Report

Merging #249 (a430cc3) into main (b992fe0) will increase coverage by 0.28%. The diff coverage is 56.03%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #249      +/-   ##
==========================================
+ Coverage   63.54%   63.83%   +0.28%     
==========================================
  Files          53       53              
  Lines        6117     6213      +96     
  Branches     1650     1683      +33     
==========================================
+ Hits         3887     3966      +79     
+ Misses       1774     1768       -6     
- Partials      456      479      +23     
Impacted Files Coverage Δ
linkml_runtime/index/object_index.py 88.28% <12.50%> (-3.53%) :arrow_down:
linkml_runtime/dumpers/rdflib_dumper.py 94.94% <40.00%> (-2.97%) :arrow_down:
linkml_runtime/utils/schemaview.py 83.14% <46.05%> (-3.27%) :arrow_down:
linkml_runtime/utils/namespaces.py 73.05% <100.00%> (+2.16%) :arrow_up:
linkml_runtime/utils/yamlutils.py 79.44% <100.00%> (+1.29%) :arrow_up:
linkml_runtime/linkml_model/meta.py 53.93% <0.00%> (+1.14%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

sierra-moxon commented 1 year ago

@joeflack4 - looks great! if possible, could you add or edit a test to take advantage of the new support for PosixPath?

joeflack4 commented 1 year ago

@cmungall I was going to look at these requests this weekend. Thanks for handling! I see as well the need to convert it to a string as well within __init__, thanks for handling that.