search

linkml / linkml-runtime

Runtime support for linkml generated models
https://linkml.io/linkml/
Creative Commons Zero v1.0 Universal
24 stars 23 forks source link

Regenerate python dataclasses for validation models #270

Closed deepakunni3 closed 1 year ago

deepakunni3 commented 1 year ago

Currently the linkml_runtime/linkml_model/validation.py is broken because of missing imports.

This PR regenerates the python dataclasses for validation models defined in linkml_runtime/linkml_model/model/schema/validation.yaml.

codecov-commenter commented 1 year ago

Codecov Report

Merging #270 (e9639ff) into main (74d699c) will increase coverage by 0.13%. The diff coverage is 74.04%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #270      +/-   ##
==========================================
+ Coverage   65.86%   65.99%   +0.13%     
==========================================
  Files          56       60       +4     
  Lines        7613     7699      +86     
  Branches     2012     2020       +8     
==========================================
+ Hits         5014     5081      +67     
- Misses       2009     2026      +17     
- Partials      590      592       +2
Impacted Files Coverage Δ
linkml_runtime/linkml_model/validation.py 0.00% <0.00%> (ø)
linkml_runtime/utils/context_utils.py 68.33% <ø> (ø)
linkml_runtime/loaders/loader_root.py 69.84% <54.28%> (+3.17%) :arrow_up:
linkml_runtime/dumpers/rdf_dumper.py 65.90% <55.55%> (-5.89%) :arrow_down:
linkml_runtime/loaders/delimited_file_loader.py 82.85% <82.85%> (ø)
linkml_runtime/dumpers/json_dumper.py 77.77% <84.61%> (-1.54%) :arrow_down:
linkml_runtime/loaders/yaml_loader.py 92.30% <85.71%> (+1.00%) :arrow_up:
linkml_runtime/utils/schemaview.py 87.79% <88.23%> (ø)
linkml_runtime/dumpers/delimited_file_dumper.py 89.65% <89.65%> (ø)
linkml_runtime/dumpers/__init__.py 100.00% <100.00%> (ø)
... and 12 more
sierra-moxon commented 1 year ago

Thanks @deepakunni3 - is the auto regeneration of these part of the makefile and/or github actions? maybe this: https://github.com/linkml/linkml-runtime/blob/6556a3e5a5fc4d4d2bca279443d7b42a9a3efbd6/Makefile#L16C1-L16C50

deepakunni3 commented 1 year ago

I had to run them manually and then push to the branch.

I did not see any github action that did autogeneration of artifacts in this repo.

Do you suggest I run gen-python for all the model YAML so that they are all in sync to the same run date?